Move to packaged Bootstrap #896
Open
+61
−6,991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 893-ionicons-web-components #896 +/- ##
===============================================================
+ Coverage 47.79% 47.87% +0.07%
===============================================================
Files 351 351
Lines 11292 11292
Branches 1889 1889
===============================================================
+ Hits 5397 5406 +9
+ Misses 5702 5694 -8
+ Partials 193 192 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
slifty
force-pushed
the
893-ionicons-web-components
branch
from
f28de58 to
be10eb6
Compare
slifty
force-pushed
the
895-package-bootstrap
branch
from
5697c84 to
dd5550f
Compare
slifty
force-pushed
the
893-ionicons-web-components
branch
from
be10eb6 to
e30817f
Compare
We had included Bootstrap v4 as vendored scss instead of loading it via npm / packages. This isn't a great practice for a couple of reasons, not the least of which being the fact that we can't benefit from things like dependabot and dependency tree checks. This intentionally does not migrate to Bootstrap v5, but simply changes how v4 is being installed. Issue #895 Remove vendored bootstrap
slifty
force-pushed
the
895-package-bootstrap
branch
from
dd5550f to
83f9ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes our "vendor" setup for Bootstrap and moves us to using an npm package instead. This will make it easier to avoid version drift and also allows us to remove third party code from our repository.
🚨 🚨 This adds a new dependency, so you'll need to run docker compose build web-app 🚨 🚨
This PR should not be merged until #894 is merged.
Resolves #895
Related to #127